Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )
Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31450/1/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/#/c/31450/1/src/device/Kconfig@252 PS1, Line 252: depends on BOARD_LENOVO_G505S We probably will not accept 'depends on BOARD_x' lines in global Kconfig files.
https://review.coreboot.org/#/c/31450/1/src/vendorcode/amd/agesa/f15tn/Proc/... File src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c:
https://review.coreboot.org/#/c/31450/1/src/vendorcode/amd/agesa/f15tn/Proc/... PS1, Line 441: (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS))) { We should not inject CONFIG_ stuff to vendorcode. I know they might be some, but should be avoided.
Also, this BottomIo should be settable from coreboot proper, from inside AMD_INIT_POST, seems to be one of AMD_POST_PARAMS structure.