12 Jan
2019
12 Jan
'19
4:02 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30881 )
Change subject: nb/intel/i945: Reduce pcidev_on_root() calls ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30881/1/src/northbridge/intel/i945/northbrid... File src/northbridge/intel/i945/northbridge.c:
https://review.coreboot.org/#/c/30881/1/src/northbridge/intel/i945/northbrid... PS1, Line 87: if (!(reg16 & 2)) { AFAICT, this bit is only about legacy VGA cycles...
Comment above where we set it (gma.c) also says that memory is still stolen.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I494aa366030b77baf431f29ba331f13f7c567025
Gerrit-Change-Number: 30881
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 12 Jan 2019 15:02:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment