Attention is currently required from: Angel Pons, Jakub Czapiga, Kapil Porwal, Maximilian Brune.
Julius Werner has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/82910?usp=email )
Change subject: treewide: Move skip_atoi function to commonlib
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Patchset:
PS4:
Isn't `skip_atoi()` supposed to return an `int`? Or is it not part of any spec?
It's not part of any spec, it's just something we made up as a simplified version of `atoi()`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82910?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifaaa80d0c696a625592ce301f9e3eefb2b4dcd98
Gerrit-Change-Number: 82910
Gerrit-PatchSet: 4
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Thu, 06 Jun 2024 17:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com