Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33155 )
Change subject: drivers/wifi: Add generic WiFi driver
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/33155/2/src/drivers/intel/wifi/Kconfig
File src/drivers/intel/wifi/Kconfig:
https://review.coreboot.org/#/c/33155/2/src/drivers/intel/wifi/Kconfig@10
PS2, Line 10: config USE_SAR
Just curious: Do the SAR configs need to be moved to the common Kconfig eventually?
https://review.coreboot.org/#/c/33155/2/src/drivers/intel/wifi/wifi.c
File src/drivers/intel/wifi/wifi.c:
https://review.coreboot.org/#/c/33155/2/src/drivers/intel/wifi/wifi.c@69
PS2, Line 69: struct
const?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33155
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica5edf95a37c8ed60f7e159d94fd58af5d41c0ef
Gerrit-Change-Number: 33155
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 14 Jun 2019 05:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment