Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43852 )
Change subject: mb/clevo/kbl-u: Install Intel VGA INT15 handler
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43852/11/src/mainboard/clevo/kbl-u/...
File src/mainboard/clevo/kbl-u/ramstage.c:
https://review.coreboot.org/c/coreboot/+/43852/11/src/mainboard/clevo/kbl-u/...
PS11, Line 21: mainboard_enable
Most boards use this name here, I would +2 a change that renames all of them at once
Coreboot coding style guide says "use descriptive names". `mainboard_enable` is maybe some sort of descriptive but simply wrong. "enable mainboard" -> "enable_mainboard". Just because XYZ does this, it's not inherently correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43852
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I126481c745ae701dc438ac664be0f8ff5f6250c1
Gerrit-Change-Number: 43852
Gerrit-PatchSet: 11
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Comment-Date: Sat, 28 Nov 2020 18:52:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment