Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36908 )
Change subject: lib/fmap.c: Properly handle cache for !C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36908/1/src/lib/fmap.c File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/36908/1/src/lib/fmap.c@81 PS1, Line 81: if (!ENV_BOOTBLOCK && CONFIG(C_ENVIRONMENT_BOOTBLOCK)) {
Looks like this will result in no signature checking for the !c_env_bootblock platforms post romstage. Do we need to expand this check to deal with both cases?
((CONFIG(C_ENVIRONMENT_BOOTBLOCK) && !ENV_BOOTBLOCK) || (!CONFIG(C_ENVIRONMENT_BOOTBLOCK) && !ENV_ROMSTAGE))
This code returns on !ENV_ROMSTAGE_OR_BEFORE. Is there a use case I'm missing or do you prefer to make it more explicit here?