Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31160 )
Change subject: soc/amd/stoneyridge: Reboot if missing MRC cache info
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31160/1/src/soc/amd/common/block/s3/s3_resum...
File src/soc/amd/common/block/s3/s3_resume.c:
https://review.coreboot.org/#/c/31160/1/src/soc/amd/common/block/s3/s3_resum...
PS1, Line 34: return;
Wouldn't we want to reboot here as well?
As a matter of style, I agree. I haven't looked to see whether mrc_cache_get_current() is kind enough to write base/size to 0 if there's an error. I'll add it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3cf2515f300decd3de198f7741660d95ee4c744
Gerrit-Change-Number: 31160
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 31 Jan 2019 03:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment