Attention is currently required from: Erik van den Bogaert, Michał Żygowski, Maciej Pijanowski, Frans Hendriks, Christian Walter, Krystian Hebel, Sergii Dmytruk.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68745 )
Change subject: security/tpm: improve tlcl_extend() signature
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Is this actually necessary? In CB:68748 TPM_MEASURE_ALGO is still a single constant, why not just use that? (I don't mind the removal of out_digest though.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I944302b502e3424c5041b17c713a867b0fc535c4
Gerrit-Change-Number: 68745
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Wed, 09 Nov 2022 01:45:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment