build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40351 )
Change subject: mb/dell/optiplex_9010: Add board support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40351/2/src/mainboard/dell/optiplex...
File src/mainboard/dell/optiplex_9010/gpio.c:
https://review.coreboot.org/c/coreboot/+/40351/2/src/mainboard/dell/optiplex...
PS2, Line 98: .gpio39 = GPIO_MODE_GPIO, /* FP_PRES# */
'PRES' may be misspelled - perhaps 'PRESS'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88d65cae30d08ca727d86d930707c2be25a527cf
Gerrit-Change-Number: 40351
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 14 Apr 2020 14:51:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment