Attention is currently required from: Angel Pons, ron minnich.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51080 )
Change subject: rk3399: clock: Fix style for rkclk_ddr_reset()
......................................................................
Patch Set 2:
(1 comment)
File src/soc/rockchip/rk3399/clock.c:
https://review.coreboot.org/c/coreboot/+/51080/comment/d8105546_81cab534
PS2, Line 253: #define RESETN_DDRPHY_REQ_SHIFT(ch) (9 + (ch) * 4)
Would it make more sense to define and use these macros? […]
This is basically how the rest of this file is written so I wanted to match the style of that (except for adding the per-channel bit).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51080
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1f5c06aabb16045d890df3bbd271f08a2cdf390
Gerrit-Change-Number: 51080
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Moritz Fischer
moritzf@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 26 Feb 2021 00:49:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment