Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46326 )
Change subject: soc/amd/common: Add weak function definitions to get ioapic IDs
......................................................................
Patch Set 3: Code-Review-1
thought a bit more about this, and since this will only return a per-soc constant and doesn't do anything that that would require it being a function, weak functions aren't the way to go here imho
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6778bf5141df580759e8158010a63d6af77e8ae
Gerrit-Change-Number: 46326
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 21 Nov 2020 00:45:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment