Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33395 )
Change subject: mb/google/octopus: Override VBT selection for Garg
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/33395/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33395/6//COMMIT_MSG@19
PS6, Line 19: Cq-Depend: chrome-internal:1380847
I don't think Cq-Depend has any meaning in the upstream repository. […]
I did see old syntax - CQ-DEPEND in the git log of coreboot in chromium side and it should still work after cherry-picking it to chromium side.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33395
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c0ec086496eaf217ea8e326f5084d886d0e698f
Gerrit-Change-Number: 33395
Gerrit-PatchSet: 6
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Jun 2019 15:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment