Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31770 )
Change subject: ec/google/chromeec: Synchronize AP RTC to the EC. ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31770/1/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/#/c/31770/1/src/ec/google/chromeec/ec.c@1087 PS1, Line 1087: if (rtc_get(&tm))
that open brace { should be on the previous line
Done
https://review.coreboot.org/#/c/31770/1/src/ec/google/chromeec/ec.c@1103 PS1, Line 1103: printk(BIOS_WARNING, "Google Chrome synced RTC time; %lu\n", (unsigned long)rtc_time_sec);
line over 96 characters
Done
https://review.coreboot.org/#/c/31770/2/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/#/c/31770/2/src/ec/google/chromeec/ec.c@1087 PS2, Line 1087: if (rtc_get(&tm)) {
braces {} are not necessary for single statement blocks
Done