Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32553 )
Change subject: soc/intel/skylake: Remove redundent mca_configure() in ramstage
......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
On AML SOCs (for Nocturne), we have seen MCEs being dumped after booting to kernel. After debugging i found MCAs were not cleared before booting the kernel so i pushed those 2 patches and with that kernel was not reporting MCEs.
(I am trying to find the crosbug but i am not able to access them, seems like i have some access issues)
@Subrata, Have you checked on SKL/KBL/AML platforms that MCEs are not dumped if you dont clear them before booting?
Clearing from cpu.c might be too early, i think. in my understanding, Clearing MCEs at that point is needed only if we need to enable SGX, as when we reload microcode for SGX we need have MCA clean.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e54fd07816c6317588ab6db06365937c4300ccd
Gerrit-Change-Number: 32553
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 May 2019 18:17:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment