Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46298 )
Change subject: device/pci: Add a common pci_dev_final() method
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46298/1/src/device/pci_device.c
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/46298/1/src/device/pci_device.c@970
PS1, Line 970: (dev->hdr_type & 0x7f) == PCI_HEADER_TYPE_NORMAL
We should probably factor the `hdr_type`+`class` match below out. And
re-use it here. But I'm not sure why we check both below.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46298
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20e98dc5aeb88f3f139079668beb52c9e722751b
Gerrit-Change-Number: 46298
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Oct 2020 21:25:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment