[coreboot-gerrit] [S] Change in coreboot[main]: mb/var/uldrenite: Configure descriptor for either MBVR or FIVR

[Jérémy Compostella (Code Review)]

Attention is currently required from: Ben Kao, Dinesh Gehlot, Eric Lai, Intel coreboot Reviewers, Jamie Chen, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik.

Jérémy Compostella has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/87033?usp=email )

Change subject: mb/var/uldrenite: Configure descriptor for either MBVR or FIVR
......................................................................

Patch Set 8:

(2 comments)

File src/mainboard/google/brya/variants/uldrenite/variant.c:

https://review.coreboot.org/c/coreboot/+/87033/comment/2c9b0173_71eb06b6?usp... :
PS6, Line 96: 0xc33,  0x72}
> Follow Intel Client SPI Programming Guide.

Please add the document reference number in the commit message where the values you are using can be found.

File src/soc/intel/alderlake/bootblock/update_descriptor.c:

https://review.coreboot.org/c/coreboot/+/87033/comment/1a07b4cf_e123267f?usp... :
PS6, Line 26: if (read32p((uintptr_t)(desc + FLASH_SIGN_OFFSET)) != FLASH_VAL_SIGN) {
            : 		printk(BIOS_ERR, "Flash Descriptor is not valid\n");
            : 		return false;
            : 	}
            : 
            : 	/* Check host has write access to the Descriptor Region */
            : 	if (!((read32p((uintptr_t)(desc + FLMSTR1)) >> FLMSTR_WR_SHIFT_V2) & BIT(0))) {
            : 		printk(BIOS_ERR, "Host doesn't have write access to Descriptor Region\n");
            : 		return false;
            : 	}
> The builder encounters an error due to a type mismatch issue, so a forced conversion is applied.

Sure, but why? This function is private to that module. It looks like you are fixing a generic issue unrelated to your commit. It should be done in a separate preceding commit.