[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h

[Angel Pons (Code Review)]

Attention is currently required from: Julius Werner, Alex James.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )

Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
......................................................................

Patch Set 6: Code-Review+1

(2 comments)

File util/cbfstool/cbfs_image.c:

https://review.coreboot.org/c/coreboot/+/60233/comment/8018d175_9ed94233 
PS6, Line 528: uint32_t type = htobe32(cur->type);
             : 
             : 		/* Current entry is empty. Kepp track of it. */
             : 		if ((type == htobe32(CBFS_TYPE_NULL)) ||
             : 		    (type == htobe32(CBFS_TYPE_DELETED))) {
This looks very stupid

https://review.coreboot.org/c/coreboot/+/60233/comment/d1686a5d_43907367 
PS6, Line 1031: be32toh(stage->loadaddr)
I wonder why this is interpreted as a 32-bit value here, it was interpreted as a 64-bit value beforehand:

shdr.sh_addr = be64toh(stage->loadaddr);