Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35849 )
Change subject: superio/nuvoton/nct5104d: Add virtual LDN for simple GPIO IO control
......................................................................
Patch Set 4:
(1 comment)
would be good if you can the commit message then i'll submit the patch
https://review.coreboot.org/c/coreboot/+/35849/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35849/4//COMMIT_MSG@11
PS4, Line 11: ff9h
Isn't it a mask for the IO base that specify the length of the resource to be allocated?
yep, the io mask specifies the resource length and the maximum address where it can be mapped. the 9 at the end in the commit message is certainly wrong, since the resource size is 8 and it needs to be aligned to a multiple of the size so i expect an 8 there
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ce99bb44e6f5db684170f4190bdc38a944849f6
Gerrit-Change-Number: 35849
Gerrit-PatchSet: 4
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jan 2020 10:59:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment