build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30973 )
Change subject: src/mainboard/sony: Add Sony VPCEH2K1E ......................................................................
Patch Set 1:
(17 comments)
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... File src/mainboard/sony/vpceh2k1e/mainboard.c:
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 30: /* 00 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x94, 0x94, 0x94, 0x94, 0x94, 0x94, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 31: /* 10 */ 0x94, 0x94, 0x05, 0x05, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 32: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 33: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x14, 0xc0, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 34: /* 40 */ 0xe3, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 35: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x06, 0x00, 0x2d, 0x29, 0x00, 0x31, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 36: /* 60 */ 0x41, 0x00, 0x00, 0xc0, 0x00, 0x00, 0x6e, 0x0a, 0x28, 0x0a, 0x01, 0x01, 0x26, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 37: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 38: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 39: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 40: /* a0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 41: /* b0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 42: /* c0 */ 0x10, 0x02, 0x00, 0x00, 0x09, 0x4a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x44, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 43: /* d0 */ 0x00, 0xff, 0x00, 0x00, 0x01, 0x00, 0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x11, 0x0b, 0x1a, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 44: /* e0 */ 0x28, 0x28, 0x28, 0x00, 0x00, 0x00, 0x58, 0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 45: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters
https://review.coreboot.org/#/c/30973/1/src/mainboard/sony/vpceh2k1e/mainboa... PS1, Line 50: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('