Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39445 )
Change subject: soc/intel/tigerlake: Fix PCI interrupts for D31 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39445/2/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/pci_irqs_tgl.asl:
https://review.coreboot.org/c/coreboot/+/39445/2/src/soc/intel/tigerlake/acp... PS2, Line 22: Package(){0x001FFFFF, 4, 0, SMBUS_IRQ }, : Package(){0x001FFFFF, 7, 0, TRACEHUB_IRQ },
Why were these removed?
We're referring with BIOS asl file and i has this setting which is same as exiting code base. And we're verifying audio for checking HDA irq. It looks interrupt setting in https://github.com/otcshare/CCG-TGL-Generic-SiC/blob/master/ClientOneSilicon... is wrong.
https://review.coreboot.org/c/coreboot/+/39445/2/src/soc/intel/tigerlake/acp... PS2, Line 21: Package(){0x001FFFFF, 0, 0, eSPI_IRQ }, : Package(){0x001FFFFF, 1, 0, P2SB_IRQ }, : Package(){0x001FFFFF, 2, 0, PMC_IRQ },
As per https://github. […]
We're referring with BIOS asl file and i has this setting which is same as exiting code base. And we're verifying audio for checking HDA irq. It looks interrupt setting in https://github.com/otcshare/CCG-TGL-Generic-SiC/blob/master/ClientOneSilicon... is wrong.
https://review.coreboot.org/c/coreboot/+/39445/2/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/irq_tgl.h:
https://review.coreboot.org/c/coreboot/+/39445/2/src/soc/intel/tigerlake/inc... PS2, Line 42: #define HDA_IRQ 19
Did you verify interrupts work correctly for HDA? It looks like this is different than what is seen […]
We're referring with BIOS asl file and i has this setting which is same as exiting code base. And we're verifying audio for checking HDA irq. It looks interrupt setting in https://github.com/otcshare/CCG-TGL-Generic-SiC/blob/master/ClientOneSilicon... is wrong.
Usually IRQ is assigned 16,17,18,19 for func 0,1,2,3 and HDA audio 19 is working in internal baseline. We'll verify audio with interrupt value 19.