Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32511 )
Change subject: mb/google/kukui: Initialize display
......................................................................
Patch Set 60:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32511/60/src/mainboard/google/kukui...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/32511/60/src/mainboard/google/kukui...
PS60, Line 109: if (!*name)
You're pointing this at an array, it can never be NULL. (I think it's fine to just display "Found ''" in that case, shouldn't happen anyway.)
https://review.coreboot.org/c/coreboot/+/32511/60/src/soc/mediatek/common/in...
File src/soc/mediatek/common/include/soc/dsi_common.h:
https://review.coreboot.org/c/coreboot/+/32511/60/src/soc/mediatek/common/in...
PS60, Line 73: u32 dsi_vfp_early_stop; /* Available since MT8183 */
Looks like this slipped into the wrong patch? (But I'm fine submitting it this way if you don't want to reorder again, nbd...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32511
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19213aee1ac0f69f42e73be9e5ab72394f412a01
Gerrit-Change-Number: 32511
Gerrit-PatchSet: 60
Gerrit-Owner: Kaka Ni
nigang@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jerry Han
hanxu5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kaka Ni
nigang@huaqin.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 13 Aug 2019 21:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment