[coreboot-gerrit] Change in coreboot[master]: libpayload/cbgfx: Remove gap between adjacent boxes

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41392 )

Change subject: libpayload/cbgfx: Remove gap between adjacent boxes
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... 
File payloads/libpayload/drivers/video/graphics.c:

https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... 
PS1, Line 82: 	while (d > INT32_MAX || d < INT32_MIN) {
> > log2 and MAX(n, d) […]

I don't see where it says implementation defined on there? It's defined by whether the data type of x is signed or unsigned. In this case, it's signed, so you will shift in a 1 if x < 0 which is exactly what you want.