Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg family C62x chipset PCI IDs
......................................................................
Patch Set 13:
(1 comment)
will check the IDs against the datasheet later
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c
File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/34941/11/util/inteltool/inteltool.c...
PS11, Line 263: _PROD
I think it is better to leave it there, since for one chipset multiple SKUs can be available. […]
IMHO the _PROD is just noise, since it is the normal case for those PCHs. To my knowledge the superset SKUs aren't even publicly available
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34941
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a1ae0cc4c5d4b02599dfafd30f4a87b3ce74b74
Gerrit-Change-Number: 34941
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 03 Sep 2019 17:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment