Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37822 )
Change subject: mainboard/google/puff: Don't enable MAX98357A in dt
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37822/7/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/37822/7/src/mainboard/google/hatch/...
PS7, Line 5: if !BOARD_GOOGLE_PUFF
That's incorrect, and if you see the history of Dan asking me to change the commit message from be […]
I can go in that direction and lean on the linker more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e437d9cd5c4bf66d39e290cc9153e08e32a3389
Gerrit-Change-Number: 37822
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Kangheui Won
khwon@chromium.org
Gerrit-Comment-Date: Mon, 23 Dec 2019 12:44:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment