Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42803 )
Change subject: soc/intel/cannonlake: make satahotplug user configurable via devicetree chip.h: add option to config fsp_params.c: copy sataHotPlug config to FSP UPD ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42803/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42803/3//COMMIT_MSG@8 PS3, Line 8: chip.h: add option to config Please add a blank line above to separate the commit message summary from the body by a blank line.
https://review.coreboot.org/c/coreboot/+/42803/3//COMMIT_MSG@8 PS3, Line 8: chip.h: add option to config : fsp_params.c: copy sataHotPlug config to FSP UPD Please format this as a list.
But just stating: *Hook up the FSP UPD* or something similar should be enough.