Patrick Rudolph has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/81882?usp=email )
Change subject: mb/*: Remove old USB configurations from SNB/bd82x6x boards
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Some boards still have the `const struct southbridge_usb_port mainboard_usb_ports[] = {` in mainboard code, which is now unused, but are missing entries in devicetree.cb. Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81882?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie1cd21077136998a6e90050c95263f2efed68a67
Gerrit-Change-Number: 81882
Gerrit-PatchSet: 7
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 11 Jan 2025 09:10:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No