16 Jul
2019
16 Jul
'19
12:01 p.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )
Change subject: mainboard/facebook/fbg1701: Add measured boot support ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/board_mboot.c:
https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... PS5, Line 33: uint32_t Why not just `unsigned int`?
https://review.coreboot.org/c/coreboot/+/33464/5/src/mainboard/facebook/fbg1... PS5, Line 34: Also the calculation is not mainboard specific, so could be moved to common code, couldn’t it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33464
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5120ffb6af0b41520056e1773f63b7b2f34a2460
Gerrit-Change-Number: 33464
Gerrit-PatchSet: 5
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jul 2019 12:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment