11 Apr
2019
11 Apr
'19
6:43 a.m.
Max Blau has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32235 )
Change subject: mainboard: Add MSI MS-7707 ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32235/4/src/mainboard/medion/ms_7707/devicet... File src/mainboard/medion/ms_7707/devicetree.cb:
https://review.coreboot.org/#/c/32235/4/src/mainboard/medion/ms_7707/devicet... PS4, Line 69: register "gpio2_output_enable" = "0x20" # 0xF1
This doesn't work. […]
Done
https://review.coreboot.org/#/c/32235/4/src/mainboard/medion/ms_7707/devicet... PS4, Line 76: register "led_vsb_mode_select" = "0x09" # 0xF9
This works but using "register" here is way too complicated. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/32235
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I999149bb95d553ed217b2288cc34bce4fe88abb3
Gerrit-Change-Number: 32235
Gerrit-PatchSet: 5
Gerrit-Owner: Max Blau
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Max Blau
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 11 Apr 2019 04:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Max Blau
Gerrit-MessageType: comment