Hello Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/32871
to review the following change.
Change subject: fit_payload: Don't call prog_segment_loaded() on extracted images ......................................................................
fit_payload: Don't call prog_segment_loaded() on extracted images
Kernel handoff on all architectures supporting FIT images already includes flushing and disabling the cache. No need to waste any more time flushing individual components (especially since in the case of compressed DT overlays they will still get accessed again afterwards).
Change-Id: I7b483e920c5a71663b024b5b50804ffc84939830 Signed-off-by: Julius Werner jwerner@chromium.org --- M src/lib/fit_payload.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/32871/1
diff --git a/src/lib/fit_payload.c b/src/lib/fit_payload.c index 4bc6622..c977903 100644 --- a/src/lib/fit_payload.c +++ b/src/lib/fit_payload.c @@ -88,12 +88,11 @@ }
if (!true_size) { - printk(BIOS_ERR, "ERROR: %s node failed!\n", comp_name); + printk(BIOS_ERR, "ERROR: %s decompression failed!\n", + comp_name); return true; }
- prog_segment_loaded(region->offset, true_size, 0); - return false; }