Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )
Change subject: mediatek/mt8183: Support get current DRAM type
......................................................................
Patch Set 12:
Patch Set 12:
Patch Set 12:
I like the idea of using Kconfig, if this is fixed per board that seems like the best option. But I'd define it in the SoC Kconfig
config MT8183_DRAM_EMCP
def_bool n
and then in Kukui's BOARD_SPECIFIC_OPTIONS you can just do
select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE
does only BOARD_GOOGLE_KUKUI be select when building image-kukui.dev.img (BOARD_GOOGLE_KRANE not be selected)
I see BOARD_GOOGLE_KUKUI and BOARD_GOOGLE_KRANE all be defined at https://review.coreboot.org/plugins/gitiles/coreboot/+/f686c6395d10ac6190c01...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34433
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267
Gerrit-Change-Number: 34433
Gerrit-PatchSet: 12
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Dawei Chien
dawei.chien@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sj Huang
sj.huang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 10 Aug 2019 03:19:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment