Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/38264 )
Change subject: gma bxt panel: Correct power-cycle delay programming ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/38264/1/common/hw-gfx-gma-panel.a... File common/hw-gfx-gma-panel.adb:
https://review.coreboot.org/c/libgfxinit/+/38264/1/common/hw-gfx-gma-panel.a... PS1, Line 81: function BXT_PP_CONTROL_PWR_CYC_DELAY (US : Natural) return Word32 is
Right. I guess I am used to having a bunch of #define for all registers.
Actually, I could make it an expression function, would at least save some distracting boilerplate.