Attention is currently required from: Alexander Couzens, Elyes Haouas.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81484?usp=email )
Change subject: mb/lenovo: Remove blank lines before '}' and after '{' ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Regarding the gpio tables, as those are generated by `util/intelp2m`. It might be a good idea to change how the script works to avoid doing this again in the future.
Maybe something roughly like (`util/intelp2m/parser/parser.go:53`): ``` func (info *padInfo) titleFprint() { if !strings.Contains(info.function, "GPIO Community 0") { fmt.Fprintf(config.OutputGenFile, "\n") } info.generate(0, "\t/* %s */\n", info.function) } ```