Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 83:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 71:
Done
Nope.
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/83/src/mainboard/asus/h110m-e... PS83, Line 213: device pnp 2e.5 on # PS/2 KBC : io 0x60 = 0x0060 : io 0x62 = 0x0064 : irq 0x70 = 1 # Keyboard : irq 0x72 = 12 # Mouse : end : device pnp 2e.6 off end # CIR : device pnp 2e.7 off end # GPIO7 : device pnp 2e.107 off end # GPIO8 : device pnp 2e.8 off end # WDT : device pnp 2e.108 off end # GPIO0 : device pnp 2e.308 off end # GPIO base : device pnp 2e.408 off end # WDTMEM : device pnp 2e.9 off end # GPIO2 : device pnp 2e.109 off end # GPIO3 : device pnp 2e.209 off end # GPIO4 : device pnp 2e.309 off end # GPIO5 : device pnp 2e.a on end # ACPI : device pnp 2e.b on # HWM, LED : io 0x60 = 0x0290 : io 0x62 = 0 : irq 0x70 = 0 : end : device pnp 2e.d off end # BCLK, WDT2, WDT_MEM : device pnp 2e.e off end # CIR wake-up : device pnp 2e.f off end # GPIO PP/OD : device pnp 2e.14 off end # SVID, Port 80 UART : device pnp 2e.16 off end # DS5 : device pnp 2e.116 off end # DS3 : device pnp 2e.316 off end # PCHDSW : device pnp 2e.416 off end # DSWWOPT : device pnp 2e.516 off end # DS3OPT : device pnp 2e.616 off end # DSDSS : device pnp 2e.716 off end # DSPU These need to be indented one more tab