Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31372 )
Change subject: soc/amd: Add support to soc merlinfalcon ......................................................................
Patch Set 2:
(2 comments)
This change is ready for review.
https://review.coreboot.org/#/c/31372/2/src/soc/amd/stoneyridge/Kconfig File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/#/c/31372/2/src/soc/amd/stoneyridge/Kconfig@26 PS2, Line 26: STONEYRIDGE_CPU_MF
This name is bugging me because they're separate products. […]
Ok, will do. I was kind of avoiding it...
https://review.coreboot.org/#/c/31372/2/src/soc/amd/stoneyridge/Kconfig@30 PS2, Line 30: For SOC MerlinFalcon, select SOC_AMD_STONEYRIDGE_FP4 and : STONEYRIDGE_CPU_MF as the only difference between StoneyRidge : and MerlinFalcon is the internal CPU, and therefore the video : (3rdparty/blobs/soc/amd/merlinfalcon) and AGESA.
It took me a while to see what you were doing here. […]
Not really. If I use SOC_AMD_MERLINFALCON_FP4, some of the code will change and no longer need selecting stoneyridge fp4. Originally I was trying to avoid lines with more than 80 characters in some places.