Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44721 )
Change subject: soc/mediatek/mt8192: Do dramc rx datlat training ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44721/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44721/6//COMMIT_MSG@8 PS6, Line 8: Please elaborate what datlat training is.
https://review.coreboot.org/c/coreboot/+/44721/6/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44721/6/src/soc/mediatek/mt8192/dra... PS6, Line 1429: dlecg_ext1 = (value >= 8) ? 1 : 0; : dlecg_ext2 = (value >= 14) ? 1 : 0; : dlecg_ext3 = (value >= 19) ? 1 : 0; Please add a comment for these limits.