Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37231 )
Change subject: security/vboot: Remove struct vboot_working_data
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37231/3/src/security/vboot/common.c
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/37231/3/src/security/vboot/common.c...
PS3, Line 91: do not employ VBOOT_STARTS_IN_ROMSTAGE
Might be clearer here to write "employ VBOOT_STARTS_IN_BOOTLBOCK"
How about "For platforms where VBOOT_STARTS_IN_BOOTBLOCK, ..."?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37231
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I304a5e4236f13b1aecd64b88ca5c8fbc1526e592
Gerrit-Change-Number: 37231
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Nov 2019 21:26:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment