[coreboot-gerrit] Change in coreboot[master]: payloads/seabios: Add Hardware IRQ Kconfig

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39869 )

Change subject: payloads/seabios: Add Hardware IRQ Kconfig
......................................................................

payloads/seabios: Add Hardware IRQ Kconfig

Certain Intel SoC platforms require SeaBIOS' HARDWARE_IRQ
option to be deselected in order for the platform to boot.
Add a Kconfig to properly select the HARDWARE_IRQ enablement
based on platform, and write to SeaBIOS' .config file in
cases where it needs to be disabled.

Test: build/boot google/clapper (Baytrail) and google/cyan
(Braswell), verify boards boot vs hanging at boot menu prompt.

Change-Id: I23e9b30d2d1042c86bd10f134d6fe361edaf8cb2
Signed-off-by: Matt DeVillier 
---
M payloads/external/SeaBIOS/Kconfig
M payloads/external/SeaBIOS/Makefile
2 files changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/39869/1

diff --git a/payloads/external/SeaBIOS/Kconfig b/payloads/external/SeaBIOS/Kconfig
index e816775..abe8815 100644
--- a/payloads/external/SeaBIOS/Kconfig
+++ b/payloads/external/SeaBIOS/Kconfig
@@ -51,6 +51,17 @@
      variations during option ROM code execution. It is not
      known if all option ROMs will behave properly with this option.

+config SEABIOS_HARDWARE_IRQ
+	prompt "Hardware Interrupts"
+	default n if SOC_INTEL_BAYTRAIL || SOC_INTEL_BRASWELL || SOC_INTEL_APOLLOLAKE
+	default y
+	bool
+	help
+	  Program and support hardware interrupts using the i8259
+	  programmable interrupt controller (PIC).  This option should
+	  be enabled for all platforms except for those which require
+	  it to be disabled (eg, Baytrail/Braswell and successors)
+
 config SEABIOS_VGA_COREBOOT
    prompt "Include generated option rom that implements legacy VGA BIOS compatibility"
    default y if !VENDOR_EMULATION
diff --git a/payloads/external/SeaBIOS/Makefile b/payloads/external/SeaBIOS/Makefile
index 0086775..cd646d9 100644
--- a/payloads/external/SeaBIOS/Makefile
+++ b/payloads/external/SeaBIOS/Makefile
@@ -72,6 +72,9 @@
 ifneq ($(CONFIG_SEABIOS_DEBUG_LEVEL),-1)
    echo "CONFIG_DEBUG_LEVEL=$(CONFIG_SEABIOS_DEBUG_LEVEL)" >> seabios/.config
 endif
+ifneq ($(CONFIG_SEABIOS_HARDWARE_IRQ),y)
+	echo "# CONFIG_HARDWARE_IRQ is not set" >> seabios/.config
+endif
 #	This shows how to force a previously set .config option *off*
 #	echo "# CONFIG_SMBIOS is not set" >> seabios/.config
    $(MAKE) -C seabios olddefconfig OUT=out/