Attention is currently required from: Matt DeVillier, Nico Huber.
Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
currently, these fan vectors are being programmed even if they are unset in the mainboard devicetree […]
Although it would currently set the registers to their defaults if there is nothing set in the devicetree, this might make sense.
But I think it can be done more elegantly without leaking "devicetree-like" configuration into the mb's Kconfig. We check `tmp_start==0` anyways to overwrite the default of 0xFF for the `CTL_LIMIT_START` register. I think it's elegant to return there and don't set any vector registers. `tmp_start` needs to be configured if one wants to use the vector functionality since the default temperature of 0xFF will effectively disable any effect the other registers have.