[coreboot-gerrit] Change in coreboot[master]: drivers/wifi: Add generic WiFi driver

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33155 )

Change subject: drivers/wifi: Add generic WiFi driver
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33155/5/src/drivers/wifi/generic.c 
File src/drivers/wifi/generic.c:

https://review.coreboot.org/c/coreboot/+/33155/5/src/drivers/wifi/generic.c@... 
PS5, Line 49: __weak
            : int get_wifi_sar_limits(struct wifi_sar_limits *sar_limits)
            : {
            : 	return -1;
            : }
Not for this change, but I am wondering if we should get rid of this weak definition. If USE_SAR is selected by a board, it should ensure that get_wifi_sar_limits is provided as well.

https://review.coreboot.org/c/coreboot/+/33155/5/src/drivers/wifi/generic.c@... 
PS5, Line 241: "WIFI%08x",
Device name can be max 4 characters long. Even if you pass in bigger string here, it will get clipped as part of acpigen_emit_simple_namestring