[coreboot-gerrit] [S] Change in coreboot[master]: build: Combine "savedefconfig" and "stripped config" in CBFS `config`

[Julius Werner (Code Review)]

Attention is currently required from: Nico Huber, Martin L Roth, Martin Roth.

Hello build bot (Jenkins), Nico Huber, Martin L Roth, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/69955

to look at the new patch set (#2).

Change subject: build: Combine "savedefconfig" and "stripped config" in CBFS `config`
......................................................................

build: Combine "savedefconfig" and "stripped config" in CBFS `config`

The intention of CB:69710 was that the expanded config file introduced
there would be a strict superset of the old version and could be used in
all the same cases. This is generally true except for a small oversight:
if a boolean Kconfig is `default y`, but was manually set to `n` by the
user, the new `config` file does not include a line for it. Running
`make olddefconfig` on such a file will again introduce the option as
`y`. It turns out that `make olddefconfig` actually parses those
"load-bearing comments" in that case.

This patch fixes the problem by also generating the minimal defconfig
(like before CB:69710), and then just appending the non-comment lines
from the full config that don't appear in it already. This ensures that
any "load-bearing comments" in the defconfig remain in the file and the
result of Kconfig utilities regenerating a full config from there will
again be the same as before CB:69710. In addition, it clearly separates
the "minimal defconfig" part of the file from the rest, making it easy
for people to extract that if they need it; while also keeping all the
config values in one file to make it easy to grep for a certain value.

Also eliminate that random backslash in the recipe that doesn't seem to
have any good reason to exist and was probably a typo to begin with.

Signed-off-by: Julius Werner 
Change-Id: I52ba5d20d3536498fae79d529acf7135f97ef1a8
---
M Makefile.inc
1 file changed, 39 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/69955/2