Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40488 )
Change subject: vc/amd/agesa/f.../Proc/Mem/Tech/DDR3: Support XMP memory profiles ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
All of this is food for thought and may be suitable for follow-up work:
The follow up commit provides AgesaCustomMemoryProfileSPD() for a manual override. How about using that mechanism to select XMP1 or XMP2, too (choosing functions that copy the values into the right spot instead of changing the compiled-in offsets)?
That way it would be easier to implement runtime selection and fallback mechanisms (e.g. use an nvram value to select the profile and use boot_count or "no XMP profile found" to fall back to a stable option)
https://review.coreboot.org/c/coreboot/+/40488/6/src/vendorcode/amd/agesa/Kc... File src/vendorcode/amd/agesa/Kconfig:
https://review.coreboot.org/c/coreboot/+/40488/6/src/vendorcode/amd/agesa/Kc... PS6, Line 8: i.e. e.g.?