All of this is food for thought and may be suitable for follow-up work:

The follow up commit provides AgesaCustomMemoryProfileSPD() for a manual override. How about using that mechanism to select XMP1 or XMP2, too (choosing functions that copy the values into the right spot instead of changing the compiled-in offsets)?

That way it would be easier to implement runtime selection and fallback mechanisms (e.g. use an nvram value to select the profile and use boot_count or "no XMP profile found" to fall back to a stable option)

Patch set 6:Code-Review +1

View Change

1 comment:

• File src/vendorcode/amd/agesa/Kconfig:

  • Patch Set #6, Line 8: i.e.

    e.g.?

To view, visit change 40488. To unsubscribe, or for help writing mail filters, visit settings.