Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32708 )
Change subject: mb/gigabyte/ga-b75m-d3{h,v}: Switch to variant setup
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32708/6/src/mainboard/gigabyte/ga-panther-po...
File src/mainboard/gigabyte/ga-panther-point/Kconfig:
https://review.coreboot.org/#/c/32708/6/src/mainboard/gigabyte/ga-panther-po...
PS6, Line 47: config DEVICETREE
: string
: default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
The only difference between the two devicetree's is the TPM. […]
I realized that too by now and wonder what differs on these boards
at all. We could join the devicetrees once the TPM is added to D3V.
And then use overrides for future boards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32708
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia175207a2568aefe1aa9bd8d4d990de6a26f1657
Gerrit-Change-Number: 32708
Gerrit-PatchSet: 6
Gerrit-Owner: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 12 May 2019 14:57:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment