Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34564 )
Change subject: mb/up/squared: Fill LPDDR4 dimm info
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34564/2/src/mainboard/up/squared/ro...
File src/mainboard/up/squared/romstage.c:
https://review.coreboot.org/c/coreboot/+/34564/2/src/mainboard/up/squared/ro...
PS2, Line 103: .ch0_rank_density = LP4_8Gb_DENSITY,
I guess there are multiple versions of the up squared.. […]
Yes there are multiple versions. As we only have one version this array has one entry for now.
Each new variant will get an entry in this skus array once we can map the straps to density.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4de63362c8fea8a886594cdcf0eec48421afb605
Gerrit-Change-Number: 34564
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 10 Sep 2019 14:41:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Gerrit-MessageType: comment