Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59245 )
Change subject: soc/mediatek/mt8186: Add support for PMIC MT6366 ......................................................................
Patch Set 3:
(3 comments)
File src/soc/mediatek/mt8186/pmic_wrap.c:
https://review.coreboot.org/c/coreboot/+/59245/comment/36c2fcdb_f9f3ad10 PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f);
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/59245/comment/a0dc969b_517b3039 PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f);
please, no space before tabs […]
Done
https://review.coreboot.org/c/coreboot/+/59245/comment/409c6b66_6c0adb43 PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f);
please, no spaces at the start of a line
Please fix.