build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39613 )
Change subject: sc7180: Add display 10nm phy & pll programming support [Patch 1 of 3] ......................................................................
Patch Set 13:
(16 comments)
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi_phy.c:
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/di... PS13, Line 731: div_ctrl = MAX(fval,0); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/di... PS13, Line 1009: { {"disp_cc_mdss_esc0_clk", 0, 1, 0, 0, 0, 0}, that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/display/mdssreg.h:
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 321: check_member(mdp_sspp_regs,sspp_sw_pic_ext_c0_req_pixels,0x108); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 321: check_member(mdp_sspp_regs,sspp_sw_pic_ext_c0_req_pixels,0x108); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 322: check_member(mdp_sspp_regs,sspp_sw_pic_ext_c1c2_req_pixels,0x118); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 322: check_member(mdp_sspp_regs,sspp_sw_pic_ext_c1c2_req_pixels,0x118); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 323: check_member(mdp_sspp_regs,sspp_sw_pic_ext_c3_req_pixels,0x128); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 323: check_member(mdp_sspp_regs,sspp_sw_pic_ext_c3_req_pixels,0x128); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 331: MDP_VP_0_SSPP_BASE = MDSS_BASE + 0x5000, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/mdss_6_2_0.h:
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 462: #define CDM_HDMI_PACK_OP_MODE REG_MDP 0x7A400 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 463: #define MDP_OUT_CTL_0 REG_MDP 0x01410 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 464: #define MDP_INTF_3_INTF_CONFIG REG_MDP 0x6C804 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 465: #define CDM_CDWN2_OUT_SIZE REG_MDP 0x7A330 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 466: #define CDM_CDWN2_OP_MODE REG_MDP 0x7A300 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 467: #define CDM_CDWN2_CLAMP_OUT REG_MDP 0x7A304 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39613/13/src/soc/qualcomm/sc7180/in... PS13, Line 468: #define CDM_CSC_10_OP_MODE REG_MDP 0x7A200 Macros with complex values should be enclosed in parentheses