build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31597 )
Change subject: security/vboot: Add fmap measurements ......................................................................
Patch Set 7:
(10 comments)
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.h File src/security/vboot/vboot_crtm.h:
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.h@49 PS7, Line 49: #if (IS_ENABLED(CONFIG_VBOOT_MEASURED_BOOT) && !ENV_BOOTBLOCK && !ENV_DECOMPRESSOR && !ENV_SMM) line over 80 characters
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c File src/security/vboot/vboot_crtm.c:
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c@104 PS7, Line 104: if (tpm_measure_region(&fmap, TPM_CRTM_PCR, "Read-only VPD") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c@108 PS7, Line 108: if (tpm_measure_region(&fmap, TPM_CRTM_PCR, "Google Binary Blob") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c@113 PS7, Line 113: if (tpm_measure_region(&fmap, TPM_CRTM_PCR, "Intel Flash Descriptor") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c@117 PS7, Line 117: if (tpm_measure_region(&fmap, TPM_RUNTIME_DATA_PCR, "Intel ME") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c@121 PS7, Line 121: if (tpm_measure_region(&fmap, TPM_RUNTIME_DATA_PCR, "EC firmware") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c@125 PS7, Line 125: if (tpm_measure_region(&fmap, TPM_CRTM_PCR, "Intel GbE") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c@129 PS7, Line 129: if (tpm_measure_region(&fmap, TPM_RUNTIME_DATA_PCR, "Platform Data") != TPM_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c@195 PS7, Line 195: if (!strncmp(fmap_runtime_data[i], name, sizeof(fmap_runtime_data[i]))) line over 80 characters
https://review.coreboot.org/#/c/31597/7/src/security/vboot/vboot_crtm.c@196 PS7, Line 196: return tpm_measure_region(rdev, TPM_RUNTIME_DATA_PCR, name); line over 80 characters