Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )
Change subject: cpu/x86: Make MP init timeout configurable
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38546/10/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/38546/10/src/cpu/x86/mp_init.c@152
PS10, Line 152: static int max(int x, int y)
Not in coreboot code base though, unless I miss something. […]
#include <stddef.h>
just use MAX macro
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38546
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc079fc6aa8641d4ac8d8e726899b6c8d055052e
Gerrit-Change-Number: 38546
Gerrit-PatchSet: 10
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 23:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment