Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41660 )
Change subject: mb/google/hatch: Split Kconfigs into BASEBOARD_HATCH and BASEBOARD_PUFF
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41660/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/41660/1/src/mainboard/google/hatch/...
PS1, Line 91: BOARD_GOOGLE_PUFF
That was introduced in https://review.coreboot. […]
SGTM. We can push a follow-up patch to enable VBOOT_EC_EFS for all of Puff.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46f8b2ed924c10228fa55e5168bf4fe6b41ec36c
Gerrit-Change-Number: 41660
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 May 2020 05:50:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment