[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: boot up sspm

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )

Change subject: google/kukui: boot up sspm
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31516/4/src/mainboard/google/kukui/Makefile.... 
File src/mainboard/google/kukui/Makefile.inc:

https://review.coreboot.org/#/c/31516/4/src/mainboard/google/kukui/Makefile.... 
PS4, Line 32: sspm-compression := $(CBFS_COMPRESS_FLAG)
> Sorry, I didn't recognize it compressed or not decided here. […]

Oh... yes, actually, that's the cause of your problem. I thought cbfs_boot_map_with_leak() would also transparently decompress things, but on closer inspection it doesn't.

I think you should just go back to having a big static uint8_t[] buffer in sspm.c and then cbfs_boot_load_file() into there (that will transparently decompress), then memcpy().